[Piglit] [PATCH 22/23] util: Add fields to piglit_gl_test_config for listing supported GL flavors

Eric Anholt eric at anholt.net
Thu Oct 4 15:31:36 PDT 2012


Chad Versace <chad.versace at linux.intel.com> writes:

> +static void
> +validate_supported_apis(const struct piglit_gl_test_config *test_config)
> +{
> +	int supported_apis = !!test_config->supports_gl_core_version
> +			   + !!test_config->supports_gl_compat_version
> +			   + !!test_config->supports_gl_es1
> +			   + !!test_config->supports_gl_es2;
> +
> +	if (supported_apis == 0) {

That's a very strange way of saying

       if (!test_config->supports_gl_core_version &&
       	   !test_config->supports_gl_compat_version &&
	   !test_config->supports_gl_es1 &&
	   !test_config->supports_gl_es2) {

:P

So, I've scanned through the series.  Other than the malloc wrappers,
it gets my acked-by.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121004/0d1ac69c/attachment.pgp>


More information about the Piglit mailing list