[Piglit] [PATCH 22/23] util: Add fields to piglit_gl_test_config for listing supported GL flavors

[Chad Versace]

On 10/04/2012 03:31 PM, Eric Anholt wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
> 
>> +static void
>> +validate_supported_apis(const struct piglit_gl_test_config *test_config)
>> +{
>> +	int supported_apis = !!test_config->supports_gl_core_version
>> +			   + !!test_config->supports_gl_compat_version
>> +			   + !!test_config->supports_gl_es1
>> +			   + !!test_config->supports_gl_es2;
>> +
>> +	if (supported_apis == 0) {
> 
> That's a very strange way of saying
> 
>        if (!test_config->supports_gl_core_version &&
>        	   !test_config->supports_gl_compat_version &&
> 	   !test_config->supports_gl_es1 &&
> 	   !test_config->supports_gl_es2) {
> 
> :P

Oops...

That's some residue from an old, unpublished patch series. In that old series,
the set of support flags was different and it was illegal for a test file to
enable more than one. Hence, there was also a check for (supported_apis > 1).

I'll replace that sum with the more sensible boolean expr in the final patch.

> So, I've scanned through the series.  Other than the malloc wrappers,
> it gets my acked-by.

Thanks for giving it a look.