[Piglit] [PATCH] util: Fix visual selection when using waffle

Eric Anholt eric at anholt.net
Tue Oct 16 18:00:26 PDT 2012

Marek Olšák <maraeo at gmail.com> writes:

> There is one test fdo25614-genmipmap which reproduces a bug only
> occuring with a framebuffer without alpha. If we enforce RGBA
> everywhere, not only would the test be useless, but also we'd end up
> with the RGBX framebuffer config mostly untested.
> While it's useful to have RGBA framebuffers in most tests, we should
> not remove support for RGBX framebuffers entirely.

I sort of agree.  I think that in cases where we have interesting
visual-specific behavior, we should test that behavior across *all*
visuals, instead of our current ad-hoc method of "let's randomly choose
between RGB and RGBA in our tests and hope that sort of covers things".
This is why I started writing tests like glx-visuals-*.

I'll go even farther than what I said before: for general,
non-visual-specific testing, let's make it just assumed that you get
alpha.  It's not worth the test developer's time in general to think
about that option for the window system buffer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121016/beb6b55f/attachment.pgp>

More information about the Piglit mailing list