[Piglit] [PATCH] util: Fix visual selection when using waffle

Marek Olšák maraeo at gmail.com
Thu Oct 18 13:50:28 PDT 2012

On Wed, Oct 17, 2012 at 2:12 AM, Ian Romanick <idr at freedesktop.org> wrote:
> On 10/16/2012 03:37 PM, Marek Olšák wrote:
>> There is one test fdo25614-genmipmap which reproduces a bug only
>> occuring with a framebuffer without alpha. If we enforce RGBA
>> everywhere, not only would the test be useless, but also we'd end up
>> with the RGBX framebuffer config mostly untested.
>> While it's useful to have RGBA framebuffers in most tests, we should
>> not remove support for RGBX framebuffers entirely.
> We should modify this test to complain if it gets a visual that has alpha.
>         glGetIntegerv(GL_ALPHA_BITS, &v)
>         if (v != 0)
>                 skip? warn? other?

The test already reports SKIP in that case.


More information about the Piglit mailing list