[Piglit] [PATCH] Add tests for the GL_AMD_performance_monitor extension.
kenneth at whitecape.org
Mon Apr 1 11:35:33 PDT 2013
On 03/28/2013 01:01 AM, Kenneth Graunke wrote:
> On 03/27/2013 12:12 AM, Ken Phillis Jr wrote:
>> I read over the patch, and I noticed a few things.
>> 1) Which platform did you test on? My guess is Linux.
> Linux with the AMD Catalyst driver, and Linux with my branch of Mesa
> that implements this.
>> 2) Where are the dynamic entry points for this extension? These tests
>> will fail on windows without this implemented.
> Gah...I was wondering about that, but since it worked I presumed that
> piglit-dispatch somehow already had support for this extension's entry
> points. But you're right, it doesn't. It only worked due to libGL ABI
> bugs. :(
Hmm. I checked generated-dispatch.h again, and piglit-dispatch (Paul's
glew replacement) does create entry points for the
AMD_performance_monitor functions. So I was wrong. The test also skips
if the extension is unsupported. I verified that it builds and runs but
skips on a system without the extension.
So, I'm not sure I understand your concern. Could you explain?
More information about the Piglit