[Piglit] [PATCH] Add tests for the GL_AMD_performance_monitor extension.
Ken Phillis Jr
kphillisjr at gmail.com
Mon Apr 1 15:15:35 PDT 2013
I have found that in some cases piglit-dispatch can fail. This means it's a
good idea to check all cases. Anyways, Have you verified that the test
works with OpenGL on windows?
Anyways, in one case where the piglit dispatcher can fail where the Core
Context fails to be created, and when trying to work with the similar
compatibility context the system fails to load extensions. A good example
of this is if you Prefer OpenGL 3.1 ( Core ) but it fails, and have the
Compatibility context set to OpenGL 3.1.
On Mon, Apr 1, 2013 at 1:35 PM, Kenneth Graunke <kenneth at whitecape.org>wrote:
> On 03/28/2013 01:01 AM, Kenneth Graunke wrote:
>> On 03/27/2013 12:12 AM, Ken Phillis Jr wrote:
>>> I read over the patch, and I noticed a few things.
>>> 1) Which platform did you test on? My guess is Linux.
>> Linux with the AMD Catalyst driver, and Linux with my branch of Mesa
>> that implements this.
>> 2) Where are the dynamic entry points for this extension? These tests
>>> will fail on windows without this implemented.
>> Gah...I was wondering about that, but since it worked I presumed that
>> piglit-dispatch somehow already had support for this extension's entry
>> points. But you're right, it doesn't. It only worked due to libGL ABI
>> bugs. :(
> Hmm. I checked generated-dispatch.h again, and piglit-dispatch (Paul's
> glew replacement) does create entry points for the AMD_performance_monitor
> functions. So I was wrong. The test also skips if the extension is
> unsupported. I verified that it builds and runs but skips on a system
> without the extension.
> So, I'm not sure I understand your concern. Could you explain?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Piglit