[Piglit] [PATCH 1/3] shader_runner: remove explicit #version from spec/glsl-1.10 tests

Tom Gall tom.gall at linaro.org
Thu Apr 4 13:07:21 PDT 2013

On Thu, Apr 4, 2013 at 11:11 AM, Eric Anholt <eric at anholt.net> wrote:
> Stuart Abercrombie <sabercrombie at chromium.org> writes:
>> It will be added based on the GLSL requirement instead.
>> Same number of passes on Sandy Bridge running all.tests without glean.
> I don't like this anti-#version crusade.  I'd like to see only patches
> to remove them if it actually makes the tests run somewhere new.  These
> tests in particular are for specific behavior of GLSL 1.10, and GLES
> should have equivalent tests that test for their particular limits.

GL ES does. The patches went in about a month ago and they live in

Related, when the variable-index-read and variable-index-write patches
to include glsl-1.00 support are accepted (hint hint), the next set of
patches I have moves both of those scripts into the generated_tests
and then deletes all the variable-index tests from tests/spec/...

That will remove a few hundred cases where one might be tempted to
fiddle with #versions in favor of auto generating appropriate
testcases for glsl 1.00, 1.10 and 1.20.

> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Tech Lead, Graphics Working Group | Linaro.org │ Open source software
for ARM SoCs
w) tom.gall att linaro.org
h) tom_gall att mac.com

More information about the Piglit mailing list