[Piglit] [PATCH 1/3] shader_runner: remove explicit #version from spec/glsl-1.10 tests

Stuart Abercrombie sabercrombie at google.com
Thu Apr 4 13:47:28 PDT 2013

I've basically been following the sequence Paul Berry suggested here:
It seems to be a reasonable way of getting to a point where some subset of
.shader_test scripts can be run with both GL and GLES.

As far as I know, removing the explicit #version directive does not in
itself make any tests run somewhere new.  It's just a prerequisite.  While
there are tests that will never transfer to GLES, continued support of
explicit #version directives means new tests will inevitably added with it
present.  If I remove it from all tests I can remove support for it, and
ensure that future tests have better odds of supporting both APIs.

Aside from this, I see them as removing redundancy, given that we already
have GLSL >= everywhere.


On Thu, Apr 4, 2013 at 9:11 AM, Eric Anholt <eric at anholt.net> wrote:

> Stuart Abercrombie <sabercrombie at chromium.org> writes:
> > It will be added based on the GLSL requirement instead.
> >
> > Same number of passes on Sandy Bridge running all.tests without glean.
> I don't like this anti-#version crusade.  I'd like to see only patches
> to remove them if it actually makes the tests run somewhere new.  These
> tests in particular are for specific behavior of GLSL 1.10, and GLES
> should have equivalent tests that test for their particular limits.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130404/916c59f3/attachment.html>

More information about the Piglit mailing list