[Piglit] [PATCH] s3tc-errors: add more glTex[Sub]Image2D() error checking tests
Eric Anholt
eric at anholt.net
Mon Apr 29 10:15:58 PDT 2013
Brian Paul <brianp at vmware.com> writes:
> Two new things:
> 1. Test small mipmap level sizes (width,height=1,2,4)
> 2. Test NPOT textures
>
> Passes with NVIDIA's driver. Checks for a Mesa bug.
> ---
> tests/texturing/s3tc-errors.c | 104 ++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 103 insertions(+), 1 deletions(-)
> + /* Try TexSubImage of larger partial block on right edge */
> + glTexSubImage2D(GL_TEXTURE_2D, 0,
> + width-3-4, 0, /* position */
> + 3+4, 4, /* size */
> + GL_RGBA, GL_UNSIGNED_BYTE, buf);
> +
> + pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
> +
> + /* Try TexSubImage of largeer partial block on top edge */
"larger"
Other than that, while I don't like how many different errors are being
covered by a single test result, it does appear to to correctly test
what we need.
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130429/daebb8d8/attachment.pgp>
More information about the Piglit
mailing list