[Piglit] [PATCH 1/2] gen_texture_query_lod_tests.py: Put function name in test filename.

[Paul Berry]

On 6 August 2013 21:33, Matt Turner <mattst88 at gmail.com> wrote:

> ---
>  generated_tests/gen_texture_query_lod_tests.py | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>

A quick note in the commit message explaining the rationale for this patch
would be nice.  (I assume you're doing this because without it, the tests
that get generated for GLSL 4.00 don't have anything in their pathname to
identify them as textureQueryLod tests).

In any case, the series is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>
> diff --git a/generated_tests/gen_texture_query_lod_tests.py
> b/generated_tests/gen_texture_query_lod_tests.py
> index 1341f7d..be30a69 100755
> --- a/generated_tests/gen_texture_query_lod_tests.py
> +++ b/generated_tests/gen_texture_query_lod_tests.py
> @@ -112,6 +112,8 @@ template = Template(dedent("""\
>  """))
>
>  for api, requirement in requirements.iteritems():
> +    Lod = 'Lod' if api == 'glsl-4.00' else 'LOD'
> +
>      for sampler_type, coord_type in
> sampler_type_to_coord_type.iteritems():
>          for execution_stage in ("vs", "fs"):
>              file_extension = 'frag' if execution_stage == 'fs' else 'vert'
> @@ -119,8 +121,9 @@ for api, requirement in requirements.iteritems():
>                                      api,
>                                      "compiler",
>                                      "built-in-functions",
> -                                    "{0}.{1}".format(sampler_type,
> -                                                     file_extension))
> +                                    "textureQuery{0}-{1}.{2}".format(Lod,
> +
> sampler_type,
> +
> file_extension))
>              print filename
>
>              dirname = os.path.dirname(filename)
> @@ -137,8 +140,6 @@ for api, requirement in requirements.iteritems():
>                      'usamplerCubeArray', 'samplerCubeArrayShadow']:
>                  extensions += ['GL_ARB_texture_cube_map_array']
>
> -            Lod = 'Lod' if api == 'glsl-4.00' else 'LOD'
> -
>              f = open(filename, "w")
>              f.write(template.render(version=version,
>                                      extensions=extensions,
> --
> 1.8.1.5
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130812/0cf9de3f/attachment.html>