[Piglit] [PATCH] Edit all.tests, add missing tests.

[Paul Berry]

On 7 August 2013 12:47, Jacob Penner <jkpenner91 at gmail.com> wrote:

> Add the following test to all.test, previously were missing.
> section                          test name
> arb_draw_elements_base_vertex    'draw-range-elements-base-vertex'
>                                  'multi-draw-elements-base-vertex'
> arb_vertex_array_bgra            'arb_vertex_array_bgra'
> ---
>  tests/all.tests | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tests/all.tests b/tests/all.tests
> index 39ee624..2bd3fd3 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -1015,6 +1015,10 @@ add_plain_test(arb_draw_elements_base_vertex,
> 'draw-elements-base-vertex-bounds'
>  arb_draw_elements_base_vertex['draw-elements-base-vertex-neg-user_varrays']
> = PlainExecTest(['draw-elements-base-vertex-neg', '-auto', 'user_varrays'])
>  add_plain_test(arb_draw_elements_base_vertex,
> 'draw-elements-instanced-base-vertex')
>  arb_draw_elements_base_vertex['draw-elements-instanced-base-vertex-user_varrays']
> = PlainExecTest(['draw-elements-instanced-base-vertex', '-auto',
> 'user_varrays'])
> +add_plain_test(arb_draw_elements_base_vertex,
> 'draw-range-elements-base-vertex')
> +arb_draw_elements_base_vertex['draw-range-elements-base-vertex-user_varrays']
> = PlainExecTest(['draw-range-elements-base-vertex', '-auto',
> 'user_varrays'])
> +add_plain_test(arb_draw_elements_base_vertex,
> 'multi-draw-elements-base-vertex')
> +arb_draw_elements_base_vertex['multi-draw-elements-base-vertex-user_varrays']
> = PlainExecTest(['multi-draw-elements-base-qvertex', '-auto',
> 'user_varrays'])
>

There are a few problems here:

1. There's an extra 'q' in the last line which prevents the test
"multi-draw-elements-base-vertex-user_varrays" from being able to run.

2. draw-range-elements-base-vertex and multi-draw-elements-base-vertex
ignore their command line arguments, so the two "user_varrays" tests are
redundant.  For now I would recommend just dropping the "user_varrays"
tests.  We can add that functionality in a later patch.

3. multi-draw-elements-base-vertex crashes when run with Mesa, since it
calls piglit_ortho_projection(), which tries to make use of
compatibility-mode-only functionality.  I think you can just drop this call
from the test.

4. multi-draw-elements-base-vertex has some type errors which cause it to
send the wrong data to the GL implementation on 64-bit systems.  However,
this is kind of a lucky mistake since it exposes a Mesa bug (it causes an
assertion failure).  So before we fix this, we should file a bug report so
we don't forget to track down the Mesa bug.  I'll show you the details when
I see you later today.

BTW, 3 and 4 should have been caught during an earlier code review--sorry
about that.

I think we should probably address 3 and 4 before landing this patch--is
that ok with you?


>
>  # Group ARB_draw_instanced
>  arb_draw_instanced = Group()
> @@ -1399,6 +1403,8 @@ add_plain_test(apple_vertex_array_object, 'vao-02')
>  apple_vertex_array_object['isvertexarray'] =
> concurrent_test('arb_vertex_array-isvertexarray apple')
>
>  profile.test_list['ARB_vertex_array_bgra/api-errors'] =
> PlainExecTest('arb_vertex_array_bgra-api-errors -auto')
> +profile.test_list['ARB_vertex_array_bgra/vertex-array-bgra'] =
> PlainExecTest('arb_vertex_array_bgra -auto')
> +
>
>  arb_vertex_array_object = Group()
>  spec['ARB_vertex_array_object'] = arb_vertex_array_object
> --
> 1.8.3.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130813/bbae6f87/attachment-0001.html>