[Piglit] [PATCH 4/9] GL3.2 GL_ARB_sync: Basic test for DeleteSync

[Kenneth Graunke]

On 07/25/2013 03:43 PM, Nicholas Mack wrote:
> ---
>   tests/spec/arb_sync/CMakeLists.gl.txt |  2 +-
>   tests/spec/arb_sync/DeleteSync.c      | 68 +++++++++++++++++++++++++++++++++++
>   2 files changed, 69 insertions(+), 1 deletion(-)
>   create mode 100644 tests/spec/arb_sync/DeleteSync.c
>
> diff --git a/tests/spec/arb_sync/CMakeLists.gl.txt b/tests/spec/arb_sync/CMakeLists.gl.txt
> index 7cb80ea..3da86a6 100644
> --- a/tests/spec/arb_sync/CMakeLists.gl.txt
> +++ b/tests/spec/arb_sync/CMakeLists.gl.txt
> @@ -10,6 +10,6 @@ link_libraries (
>   	${OPENGL_glu_LIBRARY}
>   )
>
> -piglit_add_executable (arb_sync-delete-errors DeleteSync-errors.c)
> +piglit_add_executable (arb_sync-delete-sync DeleteSync.c)
>   piglit_add_executable (arb_sync-repeat-wait repeat-wait.c)
>   piglit_add_executable (arb_sync-timeout-zero timeout-zero.c)
> diff --git a/tests/spec/arb_sync/DeleteSync.c b/tests/spec/arb_sync/DeleteSync.c
> new file mode 100644
> index 0000000..c17fd1f
> --- /dev/null
> +++ b/tests/spec/arb_sync/DeleteSync.c
> @@ -0,0 +1,68 @@
> +/* Copyright © 2013 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/*
> + *Test DeleteSync()
> + *
> + *
> + *Section 5.2(Sync Objects and Fences) on p243 of OpenGL 3.2 Core says:
> + *"A sync object can be deleted by passing its name to the command
> + * void DeleteSync( sync sync );"
> + *
> + */
> +
> +#include "piglit-util-gl-common.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +config.supports_gl_compat_version = 10;
> +config.supports_gl_core_version = 31;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +	/* UNREACHED */
> +	return PIGLIT_FAIL;
> +}
> +
> +static GLsync test;
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	bool pass = true;
> +
> +	if (piglit_get_gl_version() < 32) {
> +		piglit_require_extension("GL_ARB_sync");
> +	}
> +
> +	//Create fence sync then delete it
> +	test = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
> +	glDeleteSync(test);
> +
> +	//Check if test was deleted

/* From the ARB_sync extension specification:
  * "In either case, after returning from DeleteSync the <sync> name is
  *  invalid and can no longer be used to refer to the sync object.
  */

> +	pass = !glIsSync(test) && pass;
> +
> +	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
>

This looks good to me, but I'd just fold in with the previous test. 
You're already creating a valid sync object and deleting it there, so 
adding the !IsSync check is pretty reasonable.