[Piglit] [PATCH 2/2] GLSL 1.50: Test that struct varyings are passed correctly from GS to FS

Paul Berry stereotype441 at gmail.com
Mon Aug 26 11:23:27 PDT 2013

On 23 August 2013 11:02, Nicholas Mack <nichmack at gmail.com> wrote:

> ---
>  .../varying-struct-basic-vs-gs-fs.shader_test      | 141
> +++++++++++++++++++++
>  1 file changed, 141 insertions(+)
>  create mode 100644
> tests/spec/glsl-1.50/execution/varying-struct-basic-vs-gs-fs.shader_test
> diff --git
> a/tests/spec/glsl-1.50/execution/varying-struct-basic-vs-gs-fs.shader_test
> b/tests/spec/glsl-1.50/execution/varying-struct-basic-vs-gs-fs.shader_test
> new file mode 100644
> index 0000000..e59e2b5
> --- /dev/null
> +++
> b/tests/spec/glsl-1.50/execution/varying-struct-basic-vs-gs-fs.shader_test

The name is a little misleading, since this test only verifies varying
structs going from gs to fs.  I'd recommend renaming this test to

With the name changed, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>

As a follow-up patch, I think we also need to test structured varyings
going from vs to gs.  (The vs to gs case is important since gs inputs are
arrays, so it's likely that vs to gs varying structs exercise a different
code path).  Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130826/b45f98f3/attachment-0001.html>

More information about the Piglit mailing list