[Piglit] [PATCH 08/16] glsl-1.40: Refector pass-through vertex shader out to its own file

Eric Anholt eric at anholt.net
Mon Aug 26 16:14:12 PDT 2013

Ian Romanick <idr at freedesktop.org> writes:

> From: Ian Romanick <ian.d.romanick at intel.com>
> Instead of replicating the same code over and over and over, just put it
> in one file that each shader test can reference.

I've been meaning to kill "[vertex/fragment shader file]" support from
shader_runner for a while. :(

What I don't like about it is that it scatters the information about a
particular test to more places, which shader_runner had helped reduce
significantly.  And this feature is used very rarely -- looking at the
current list of tests using it, they mostly look like the first few
shader_runner tests we made.

For the changes you wanted to do in this series, a sed job looks like it
would have been just fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130826/97f323d2/attachment.pgp>

More information about the Piglit mailing list