[Piglit] [PATCH 08/16] glsl-1.40: Refector pass-through vertex shader out to its own file

Ian Romanick idr at freedesktop.org
Mon Aug 26 16:53:30 PDT 2013

On 08/26/2013 04:14 PM, Eric Anholt wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>> Instead of replicating the same code over and over and over, just put it
>> in one file that each shader test can reference.
> I've been meaning to kill "[vertex/fragment shader file]" support from
> shader_runner for a while. :(
> What I don't like about it is that it scatters the information about a
> particular test to more places, which shader_runner had helped reduce
> significantly.  And this feature is used very rarely -- looking at the
> current list of tests using it, they mostly look like the first few
> shader_runner tests we made.
> For the changes you wanted to do in this series, a sed job looks like it
> would have been just fine.

I think it's not used much because most people don't know it's 
available.  These are the (only?) cases where it's useful: you don't 
want to type the dummy, pass-through vertex shader over and over and 
over.  Maybe we should replace it with a more limited "[vertex shader 
passthrough]" option?

I did the refactor in this series mostly to reduce the amount of reading 
in the patches that counted.  I also tried a sed job (via emacs macros), 
but many of the pass-through shaders were very slightly different. :(

More information about the Piglit mailing list