[Piglit] RFC: variable-index-read.sh and write for GLES

Eric Anholt eric at anholt.net
Wed Feb 27 11:38:04 PST 2013


Tom Gall <tom.gall at linaro.org> writes:

> From tests/spec/glsl-1.10,  I've extended variable-index-write.sh and
> variable-index-read.sh so the scripts are able to generate tests for
> GLSL ES 1.00.
>
> Posting the patches for the scripts is trivial but how do we want to
> handle all the tests that it generates?
>
> Seems like a bit of a waste of mailing list bandwidth to post the 326
> resulting new files as patches that are output from the scripts.

I maintain that we shouldn't be checking in generated files like these.
Worst case where we can't decide to not check them in, just trim your
patch to an interesting subset to demo what happens.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130227/8a02c9eb/attachment.pgp>


More information about the Piglit mailing list