[Piglit] [PATCH 4/4] glean/pointsprite: Initialize PointSpriteTest member variables.

Brian Paul brian.e.paul at gmail.com
Tue Jan 1 08:05:00 PST 2013


On Thu, Dec 20, 2012 at 12:15 AM, Vinson Lee <vlee at freedesktop.org> wrote:
> Fixes uninitialized scalar field defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/glean/tpointsprite.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/glean/tpointsprite.h b/tests/glean/tpointsprite.h
> index 089afa0..9901543 100644
> --- a/tests/glean/tpointsprite.h
> +++ b/tests/glean/tpointsprite.h
> @@ -45,7 +45,10 @@ class PointSpriteTest: public MultiTest
>      public:
>         PointSpriteTest(const char* testName, const char* filter,
>                  const char *extensions, const char* description):
> -                MultiTest(testName, filter, extensions, description){
> +                MultiTest(testName, filter, extensions, description),
> +                texImages(),
> +                mTolerance(),
> +                have_2_0(false) {
>         }
>
>         virtual void runOne(MultiTestResult &r, Window &w);

These four look OK to me.

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the Piglit mailing list