[Piglit] [PATCH] arb_es2_compatibility-releaseshadercompiler-ge7: test glReleaseShaderCompiler crash

Chad Versace chad.versace at linux.intel.com
Mon Jan 7 12:21:15 PST 2013


On 12/18/2012 02:43 PM, Brian Paul wrote:
> This tests exercises a Mesa crash found with Google Earth v7.
> Specifically, Google Earth is calling glReleaseShaderCompiler() between
> glCompileShader() and glLinkProgram().
> 
> It appears that glReleaseShaderCompiler() is freeing some data
> structures that are needed later by the linker.
> 
> The test passes with NVIDIA's driver.
> ---

Looks good to me.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

I'm surprised that you explicitly set config.window_width/height
rather than leaving them at the defaults. Did you intend to do that?

> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +	config.supports_gl_compat_version = 10;
> +
> +	config.window_width = 100;
> +	config.window_height = 100;
> +	config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_ALPHA | PIGLIT_GL_VISUAL_DOUBLE;
> +
> +PIGLIT_GL_TEST_CONFIG_END



More information about the Piglit mailing list