[Piglit] [PATCH] Clarify comment about glIsBuffer behavior

Eric Anholt eric at anholt.net
Fri Jan 25 09:35:44 PST 2013


Matt Turner <mattst88 at gmail.com> writes:

> The spec's not vague, it's just stupid. glIsBuffer should return false
> between the time a buffer name is generated and first bound.
> ---
>  tests/general/isbufferobj.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tests/general/isbufferobj.c b/tests/general/isbufferobj.c
> index 3938d18..d805818 100644
> --- a/tests/general/isbufferobj.c
> +++ b/tests/general/isbufferobj.c
> @@ -78,10 +78,8 @@ test(void)
>     }
>  
>     /*
> -    * The GL spec is vague here.  But the GL man pages say glIsBuffer should
> -    * return false in this case.  Mesa and NVIDIA's driver return true.
> -    * Generate a warning, not an error, if the driver doesn't follow the
> -    * GL docs here.
> +    * Generate a warning, not an error, if the driver doesn't return
> +    * GL_FALSE from glIsBuffers if the buffer has never been bound.
>      */
>     if (glIsBuffer(buffers[1])) {
>        printf("%s: glIsBuffer(%u) returned true instead of false.\n",

Why should we generate a warning, not an error, if the spec is clear?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130125/37225814/attachment.pgp>


More information about the Piglit mailing list