[Piglit] [PATCH] depth_texture_mode_and_swizzle: request alpha channel

Eric Anholt eric at anholt.net
Tue Jan 29 03:06:58 PST 2013

Jose Fonseca <jfonseca at vmware.com> writes:

> Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
> I assume that PIGLIT_GL_VISUAL_RGBA came from GLUT_RGBA, but given
> that it is a misleading alias for PIGLIT_GL_VISUAL_RGB and there is no
> need to be bug compatible with glut, I believe that in a follow on
> change we should eliminate PIGLIT_GL_VISUAL_RGBA alias, so that test
> writers can immediately notice that they need to add
> PIGLIT_GL_VISUAL_ALPHA when they want it.

I think that letting developers choose to only probe RGB and not look at
A has been a mistake.  I don't think we should be encouraging new tests
to use an RGB-only visual and test without alpha.

If you have particular things that non-alpha visuals may have issues
with, then you want a test that enumerates visuals.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130129/9880729d/attachment.pgp>

More information about the Piglit mailing list