[Piglit] [PATCH] depth_texture_mode_and_swizzle: request alpha channel

Jose Fonseca jfonseca at vmware.com
Tue Jan 29 03:33:41 PST 2013

----- Original Message -----
> Jose Fonseca <jfonseca at vmware.com> writes:
> > Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
> >
> > I assume that PIGLIT_GL_VISUAL_RGBA came from GLUT_RGBA, but given
> > that it is a misleading alias for PIGLIT_GL_VISUAL_RGB and there is
> > no
> > need to be bug compatible with glut, I believe that in a follow on
> > change we should eliminate PIGLIT_GL_VISUAL_RGBA alias, so that
> > test
> > writers can immediately notice that they need to add
> > PIGLIT_GL_VISUAL_ALPHA when they want it.
> I think that letting developers choose to only probe RGB and not look
> at
> A has been a mistake.  I don't think we should be encouraging new
> tests
> to use an RGB-only visual and test without alpha.

Yes, that's a valid point.

> If you have particular things that non-alpha visuals may have issues
> with, then you want a test that enumerates visuals.

I personally see little value in visual enumeration on modern FBO-capable drivers. It is fair to assume that GL drivers unify these concepts internally, and only enumerate all FBO formats.


More information about the Piglit mailing list