[Piglit] [PATCH 02/18] shader_runner: Allow new drawing modes.

[Paul Berry]

On 10 June 2013 16:54, Eric Anholt <eric at anholt.net> wrote:

> Fabian Bieler <fabianbieler at fastmail.fm> writes:
>
> > Add primitives with adjacency and (for extreme future-proofness) patches
> to
> > recognized drawing modes.
> > ---
> >  tests/shaders/shader_runner.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/shaders/shader_runner.c
> b/tests/shaders/shader_runner.c
> > index 515fde1..e022b90 100644
> > --- a/tests/shaders/shader_runner.c
> > +++ b/tests/shaders/shader_runner.c
> > @@ -1481,8 +1481,13 @@ GLenum
> >  decode_drawing_mode(const char *mode_str)
> >  {
> >       int i;
> > +#ifdef PIGLIT_USE_OPENGL
> > +     const GLenum max_prim_type = GL_PATCHES;
> > +#else
> > +     const GLenum max_prim_type = GL_POLYGON;
> > +#endif
>
> Both GLES2/3 and desktop enums should be available in both builds now,
> so no need for ifdefs -- just always use GL_PATCHES.
>

Actually, Eric's series that allows this (
http://lists.freedesktop.org/archives/piglit/2013-June/005927.html) hasn't
landed yet.  So if you take this suggestion, wait for Eric to land his
series first.

With or without Eric's suggested change, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130613/ce8a6d05/attachment.html>