[Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

Dylan Baker baker.dylan.c at gmail.com
Sat May 18 21:35:46 PDT 2013

My problem with the current list format is its too complex, and is trying
to solve nonexistent problems. There is no reason one should need to rename
the test results in the HTML summary. It's only going to lead to headaches
later on trying to identify what is actually in that column "corrected

I personally like either nothing, since it doesn't appear that is a popular
feature, or a simple space, coma, or new line separated list of results
files. Its clean, simple, and doesn't require much explanation.
On May 17, 2013 3:14 PM, "Ken Phillis Jr" <kphillisjr at gmail.com> wrote:

> On Fri, May 17, 2013 at 3:27 PM, Dylan Baker <baker.dylan.c at gmail.com>
> wrote:
> > You're probably right. I'll make that change too.
> >
> > Though I am wondering if it's even worth having the list syntax, it's
> been
> > broken for over two months and no one has complained or even noticed it
> > until now. If it's still useful to someone I'll fix it, but if no one's
> > using it it is a fairly clunky mechanism. I'd prefer to see just a space,
> > comma, or newline separated list of files in a file rather than the
> python
> > list of lists that behaves rather strangely.
> >
> >
> The broken list syntax was hidden by the broken relative to absolute
> path resolution that was broken at the same time... Anyways, I do
> agree that the old list format is not the best... It should be
> possible to instead change the list format to use a true json format
> similar to how test results are stored... An example of this would be
> as follows:
> {
>     'path-to-result-1-directory': {},
>     'path-to-result-2/main': null,
>     'path-to-result-3-path': { 'name': 'This is the Corrected Name' },
>     'path-to-result-4/main': { 'name': 'Yet another Corrected Name' }
> }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130518/5b9c53b1/attachment.html>

More information about the Piglit mailing list