[Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML
kenneth at whitecape.org
Sat May 18 23:07:20 PDT 2013
On 05/18/2013 09:35 PM, Dylan Baker wrote:
> My problem with the current list format is its too complex, and is
> trying to solve nonexistent problems. There is no reason one should need
> to rename the test results in the HTML summary. It's only going to lead
> to headaches later on trying to identify what is actually in that column
> "corrected name".
> I personally like either nothing, since it doesn't appear that is a
> popular feature, or a simple space, coma, or new line separated list of
> results files. Its clean, simple, and doesn't require much explanation.
Personally, I see no value in the ability to load a list of results
files. Specifying them on the command line works just fine. I had
assumed it was a newline or space separated list, but apparently it's
something more complicated. I don't even know the syntax, and I've been
using Piglit for years...
Does anybody even use that feature?
I also don't understand the need to rename the columns when specifying
the result files. If I want to rename a result (usually because I
typo'd when doing piglit-run), I just edit the file and change the name...
I'm not a fan of making this a fancy json syntax unless there's a real
compelling use case.
More information about the Piglit