[Piglit] [v6] Tests for EXT_image_dma_buf_import

[Pohjolainen, Topi]

On Tue, May 21, 2013 at 12:09:31AM +0200, Daniel Vetter wrote:
> On Thu, May 16, 2013 at 12:51:13PM +0300, Topi Pohjolainen wrote:
> > Here are some tests for the dma buffer importing. These are mostly
> > things specifically listed down in the spec itself regarding
> > attributes and their values. This version two adds three additional
> > tests for sampling packed RGB, but testing of more complex planar
> > (YUV) formats is left until one has the sampling support in place
> > provided by the image external extension.
> > 
> > I augmented the framework to provide platform independent interface
> > for creating and releasing the target buffers. I hope to re-use the
> > logic for the external image testing later on.
> > 
> > v2-v4:
> >    - clarifications on closing the buffers
> >    - added tests sampling RGB formatted buffers
> >    - check for EGL extensions, not for GL (added a utility for this)
> > 
> > v5:
> >    - split tests into individual commits
> >    - introduced common header for drm fourcc formats
> > 
> > v6:
> >    - various fixes according to review comments from Eric, Chad,
> >      Daniel and Ken
> >    - refactored dri2-authentication from Chad's revision of dma
> >      buffer support into its own patch. I had fixes for other
> >      review comments already in my version of the base patch.
> > 
> > 
> > Chad: Please check if you agree into conditionally including the
> >       authentication support. I'm fine having it as you proposed
> >       originally. I just couldn't get it working on my Ubuntu
> >       laptop, and not being too familiar with the mechanism in
> >       general I thought better getting stuff for review as I have
> >       revisioned the series heavily.
> > 
> > Eric,Chad,Daniel: In my system subsequent call of 'close()'
> >                   against the same file descriptor returns -1
> > 		  instead of EBADF. Hence I just check that the
> > 		  return value differs from zero.
> 
> libc convention is to set the return value to an unconditional -1 and set
> errno to the right (positive) error code. So you need to check for
> 
> 	ret = close(fd);
> 	assert(ret == -1 && errno == EBADF);

Thanks, I'll wait for feedback from others and fix it accordingly.

-Topi