[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

Ian Romanick idr at freedesktop.org
Fri Nov 1 21:09:07 CET 2013


On 11/01/2013 10:20 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> ---
>  tests/spec/gl-3.1/minmax.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c
> index 1128939..c965ebe 100644
> --- a/tests/spec/gl-3.1/minmax.c
> +++ b/tests/spec/gl-3.1/minmax.c
> @@ -79,7 +79,9 @@ piglit_init(int argc, char **argv)
>  	piglit_test_range_float(GL_POINT_SIZE_RANGE, 1, 1);
>  	piglit_test_range_float(GL_ALIASED_LINE_WIDTH_RANGE, 1, 1);
>  	piglit_test_range_float(GL_SMOOTH_LINE_WIDTH_RANGE, 1, 1);
> -	piglit_test_min_int(GL_NUM_COMPRESSED_TEXTURE_FORMATS, 4);
> +	/* The spec lists 4, but the number should be 0, because hw drivers
> +	 * don't have to expose any non-core extensions like S3TC. */
> +	piglit_test_min_int(GL_NUM_COMPRESSED_TEXTURE_FORMATS, 0);

It said 4 because someone mistakenly counted the RGTC formats.  Also
worth noting is that the mistake was fixed in GL 4.2.

With that changed,

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I guess tests/spec/gl-3.2/minmax.c and tests/spec/gl-3.3/minmax.c
probably need the same fix?

>  	piglit_test_min_int(GL_MAX_TEXTURE_BUFFER_SIZE, 65536);
>  	piglit_test_min_int(GL_MAX_RECTANGLE_TEXTURE_SIZE, 1024);
>  
> 



More information about the Piglit mailing list