[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

[Ken Phillis Jr]

On Fri, Nov 1, 2013 at 12:20 PM, Marek Olšák <maraeo at gmail.com> wrote:

> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>  tests/spec/gl-3.1/minmax.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c
> index 1128939..c965ebe 100644
> --- a/tests/spec/gl-3.1/minmax.c
> +++ b/tests/spec/gl-3.1/minmax.c
> @@ -79,7 +79,9 @@ piglit_init(int argc, char **argv)
>         piglit_test_range_float(GL_POINT_SIZE_RANGE, 1, 1);
>         piglit_test_range_float(GL_ALIASED_LINE_WIDTH_RANGE, 1, 1);
>         piglit_test_range_float(GL_SMOOTH_LINE_WIDTH_RANGE, 1, 1);
> -       piglit_test_min_int(GL_NUM_COMPRESSED_TEXTURE_FORMATS, 4);
> +       /* The spec lists 4, but the number should be 0, because hw drivers
> +        * don't have to expose any non-core extensions like S3TC. */
> +       piglit_test_min_int(GL_NUM_COMPRESSED_TEXTURE_FORMATS, 0);
>         piglit_test_min_int(GL_MAX_TEXTURE_BUFFER_SIZE, 65536);
>         piglit_test_min_int(GL_MAX_RECTANGLE_TEXTURE_SIZE, 1024);
>
> --
> 1.8.1.2
>
>

I Believe it will probably be better to leave this alone, and instead at
least support one texture compression... There is a new core extension
required by OpenGL 4.3 that should be important to note. OpenGL 4.3
requires support for the ASTC compression.

* GL_ARB_texture_compression_rgtc - Promoted to Core feature as of OpenGL
3.0

See Section F.1 ( Page 301 ) of the OpenGL 3.0 Core Specification. This
specifically states as a new feature "RGTC specific internal compressed
formats (GL_EXT_texture_compression_rgtc)."

NOTE: This has not changed much, but was reworded... So also reconfirm
against Section : "H.3.3.45 RGTC Texture Compression Formats" on page 692
of the OpenGL 4.4 core specification.
http://www.opengl.org/registry/specs/ARB/texture_compression_rgtc.txt

* GL_ARB_texture_compression_bptc - Promoted to Core feature as of OpenGL
4.2
http://www.opengl.org/registry/specs/ARB/texture_compression_bptc.txt

* Adaptive Scalable Texture Compression
http://en.wikipedia.org/wiki/Adaptive_Scalable_Texture_Compression

* KHR_texture_compression_astc_hdr  - Promoted to Core feature as of OpenGL
4.3
http://www.opengl.org/registry/specs/KHR/texture_compression_astc_hdr.txt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131101/7d99141b/attachment.html>