[Piglit] [PATCH 00/13] Signal Handler and GLFW framework

[Ken Phillis Jr]

I had to add a few more patches to the commit list due to bugs I found.


* git: add install_manifest.txt to gitignore

This is simple enough... When you type "Make Package" you will wind up
having a file called install_manifest.txt appear.


* cmake: Install templates on make package.
Another simple enough bug... The Installation results did not include the
mako template files for html.


Also, I spotted two things th at really need to be paid attention to...

1) pkg-config usage in cmake... The current system works well enough on
linux, but when you go to windows or other operating systems this can
rapidly cause problems because not all platforms have this by default. The
best example of this is what is going on with Linux. The FindPkgConfig
module has a nice little FOUND flag called PKG_CONFIG_FOUND. We should use
this before making any calls to the to the commands pkg_check_modules and
pkg_search_module.

2) Some tests have insanely long file names and test names. 70+ Character
file names and test names may be nice on most platforms but it generates
problems for windows/linux... I suggest trying to limit the file name to at
most 32 characters. This is because of how piglit works using the cmake
script work. Two good examples are as follows.

* same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT

Results in a file called:
target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.dir/same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.c.o

This is 200 characters on it's own... this throws a lot of errors with the
generators on windows.


* same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT

Same problem as the other test. This results in a 206 character long path...
target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.dir/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.c.o


I believe there may be more but this should be a good start.

3) This may not sound like much, but html generation on windows is broken.
This is due to Illegal Characters in File/Folder names. There is a couple
of articles over this and it is not exactly hard to implement. Please refer
to the following Wikipedia article (
http://en.wikipedia.org/wiki/Filename) and pay attention to the
filename limitations.


On Sun, Nov 3, 2013 at 9:54 AM, Ken Phillis Jr <kphillisjr at gmail.com> wrote:

> Since some patches landed that did not allow my patch set to apply
> Cleanly, I went ahead and updated my local tree and placed the patches on
> github. The patches are in my glfw-sig-patch branch on github. The commit
> history is located at...
>
> https://github.com/kphillisjr/piglit/commits/glfw-sig-patch
>
>
>
> On Fri, Nov 1, 2013 at 2:31 PM, Ken Phillis Jr <kphillisjr at gmail.com>wrote:
>
>> I added two more changes to this patch series. For patches the following
>> patches
>> * piglit-framework-gl: Add piglit signal handler.
>> * util: Implement signal handler on windows.
>>
>> The change is to have all output except for...
>> PIGLIT: {'result': 'crash' }
>>
>> changed to print to stderr instead of stdout. This will make it to where
>> the summary
>> information to html will have the callstack on top.
>>
>>
>>
>>
>> On Thu, Oct 31, 2013 at 12:27 PM, Ken Phillis Jr <kphillisjr at gmail.com>wrote:
>>
>>> I have applied the suggestions that Dylan Baker suggested to the
>>> following patches.
>>>
>>> *  framework/summary.py: add crashed page.
>>> *  cmake: use PythonInterp package and update version.
>>>
>>> I will be submitting the updated patch set in a few days after I get
>>> more feedback on the
>>> other patches.
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131104/09c27fcd/attachment.html>