[Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

Dylan Baker baker.dylan.c at gmail.com
Tue Oct 1 14:37:51 PDT 2013


On Monday, September 30, 2013 10:11:05 PM Kenney Phillis wrote:
> Increase the Minimum version of CMake that is required from
> version 2.6 to version 2.8. This is because the minimum requirement
> to compile waffle is version 2.8
> ---
>  CMakeLists.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index f064b35..0da074a 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -1,4 +1,4 @@
> -cmake_minimum_required(VERSION 2.6)
> +cmake_minimum_required(VERSION 2.8)
> 
>  list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules")

I don't think we need this. Waffle is a seperate project and a not a dependency 
(if running on non-linux platforms), besides that dependency ordering is waffle 
then piglit, so either you have 2.8, or you don't need it.

Just my 2cents.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131001/515aac89/attachment.pgp>


More information about the Piglit mailing list