[Piglit] [PATCH V9] KHR_debug: test ObjectLabel(), GetObjectLabel(), ObjectPtrLabel() and GetObjectPtrLabel()

Eric Anholt eric at anholt.net
Mon Oct 7 17:52:21 CEST 2013


I've pushed the test now.  I made some trivial fixes on the way:
whitespace consistency, but also fixing duplication of the extension
name in the summary results.

Thanks for all your work on this!

diff --git a/tests1   /all.tests b/tests/all.tests
index 3e5e1a3..cec532a 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1319,7 +1319,7 @@ add_plain_test(arb_debug_output, 'arb_debug_output-api_error')
 # Group KHR_debug
 khr_debug = Group()
 spec['KHR_debug'] = khr_debug
-add_plain_test(khr_debug, 'khr_debug-object-label')
+khr_debug['object-label'] = concurrent_test('khr_debug-object-label')
 
 # Group ARB_occlusion_query2
 arb_occlusion_query2 = Group()
diff --git a/tests/spec/khr_debug/debug-object-label.c b/tests/spec/khr_debug/debug-object-label.c
index 6905619..2fabebd 100644
--- a/tests/spec/khr_debug/debug-object-label.c
+++ b/tests/spec/khr_debug/debug-object-label.c
@@ -73,7 +73,7 @@ test_object_ptr_label()
 
 	if (!piglit_check_gl_error(GL_INVALID_VALUE)) {
 		fprintf(stderr, "GL_INVALID_VALUE should be generated when ObjectPtrLabel()"
-		        " ptr is not the name of a sync object\n");
+			" ptr is not the name of a sync object\n");
 		pass = false;
 	}
 
@@ -282,7 +282,7 @@ test_object_label()
 	GLchar label[TestLabelLen + 1];
 	GLchar *bigLabel;
 	bool pass = true;
-        int maximumLabelLengthTest = 1024; /* Be defensive about the size label length test to avoid memory issues */
+	int maximumLabelLengthTest = 1024; /* Be defensive about the size label length test to avoid memory issues */
 
 	puts("Test ObjectLabel");
 
@@ -320,7 +320,7 @@ test_object_label()
 	}
 	else {
 		printf("MAX_LABEL_LENGTH test skipped as implementations MAX_LABEL_LENGTH=%i and max piglit test length=%i\n",
-                       maxLabelLength, maximumLabelLengthTest);
+		       maxLabelLength, maximumLabelLengthTest);
 	}
 
 	/* If <label> is NULL, any debug label is effectively removed from the object.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131007/a53e8572/attachment.pgp>


More information about the Piglit mailing list