[Piglit] [PATCH 1/8] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

Chad Versace chad.versace at linux.intel.com
Mon Oct 14 17:50:28 CEST 2013


Thanks for the cleanups and fixes. I've committed patches 1,3-7 with minor fixes.
I've added a v4 annotation for each patch.

As for the patch subject, the convention is that we use a simpler prefix. If a test is
for an extension that was later promoted to a real OpenGL version, like GL_ARB_sync,
then a prefix like this is good:
	GL_ARB_sync: Test to check the whatsit
Or, if the test is placed into a certain directory, like arb_sync, then this is
good too:
	arb_sync: Test to check the whatsit
I've modified all patches to match the second convention.

I believe the last testcase of patch 8 is incorrect. See my reply to that patch.
I'm still reviewing patch 2. I should be done before lunch.


More information about the Piglit mailing list