[Piglit] [PATCH 1/3] piglit-run: add back -c0

Chad Versace chad.versace at linux.intel.com
Thu Sep 19 16:02:49 PDT 2013


On 09/17/2013 08:43 AM, Dylan Baker wrote:
> On Monday 16 September 2013 20:08:33 Marek Olšák wrote:
>> ---
>>   piglit-run.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/piglit-run.py b/piglit-run.py
>> index e8e11b7..7945b21 100755
>> --- a/piglit-run.py
>> +++ b/piglit-run.py
>> @@ -62,7 +62,7 @@ def main():
>>                           action  = "append",
>>                           metavar = "<regex>",
>>                           help    = "Exclude matching tests (can be used more
>> than once)") -    parser.add_argument("--no-concurrency",
>> +    parser.add_argument("-c0", "--no-concurrency",
>>                           action  = "store_false",
>>                           dest    = "concurrency",
>>                           help    = "Disable concurrent test runs")
>
> I'm not thrilled with the -c0 flag. Could we use a '-nc' or '-n' instead?

The form "-${flag}${value}" for single-letter flags follows a Unix tradition.
'-nc' for "not c" does not. I'm ok adding back -c0, but I don't feel strongly
about it. This has my r-b for what it's worth.


More information about the Piglit mailing list