[Piglit] [PATCH 1/3] piglit-run: add back -c0
Dylan Baker
baker.dylan.c at gmail.com
Fri Sep 20 10:31:03 PDT 2013
On Thursday 19 September 2013 16:02:49 Chad Versace wrote:
> On 09/17/2013 08:43 AM, Dylan Baker wrote:
> > On Monday 16 September 2013 20:08:33 Marek Olšák wrote:
> >> ---
> >>
> >> piglit-run.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/piglit-run.py b/piglit-run.py
> >> index e8e11b7..7945b21 100755
> >> --- a/piglit-run.py
> >> +++ b/piglit-run.py
> >>
> >> @@ -62,7 +62,7 @@ def main():
> >> action = "append",
> >> metavar = "<regex>",
> >> help = "Exclude matching tests (can be used
> >> more
> >>
> >> than once)") - parser.add_argument("--no-concurrency",
> >> + parser.add_argument("-c0", "--no-concurrency",
> >>
> >> action = "store_false",
> >> dest = "concurrency",
> >> help = "Disable concurrent test runs")
> >
> > I'm not thrilled with the -c0 flag. Could we use a '-nc' or '-n' instead?
>
> The form "-${flag}${value}" for single-letter flags follows a Unix
> tradition. '-nc' for "not c" does not. I'm ok adding back -c0, but I don't
> feel strongly about it. This has my r-b for what it's worth.
I'm fine with -c 0, but i just think that -c0 feel clunky.
Either way, it was only a suggestion.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130920/57150d73/attachment.pgp>
More information about the Piglit
mailing list