[Piglit] Over three thousand crashes on opengl driver of ADM&NV caused by commit b28cdc887aefb1e766719e1f74d457f77bdf9a18

[Jordan Justen]

On Thu, Apr 3, 2014 at 2:42 AM, Fu, Ping <Ping.Fu at amd.com> wrote:
> Hi Justen,
>
> I tested the latest piglit and found lots of crashes(Over three thousand) on
> both AMD and NVIDIA. This might be caused by your commit
> b28cdc887aefb1e766719e1f74d457f77bdf9a18 on shader_runner.c.

Does the attached patch help?

What is an example test that you see failing?

Thanks,

-Jordan

> According to page 363 and 360 of glspec44.compatibility for glVertexPointer:
> "An INVALID_OPERATION error is generated if a non-zero vertex array object
> is bound, no buffer is bound to ARRAY_BUFFER, and pointer is not NULL."  So
> if app who wants to use VAO, should obey the following gl call sequence:
>
>
>
> glGenVertexArrays
>
> glBindVertexArray
>
> glGenBuffers
>
> glBindBuffer
>
> glBufferData
>
> glVertexAttribPointer
>
>
>
> But now the red part missed under current code path when
> use_fixed_function_attributes and INVALID_OPERATION was returned by
> subsequent glVertexAttribPointer. Then both AMD and NVIDIA crashed on
> subsequent glDrawArrays. Besides, mesa driver's gl_version=30 so it followed
> another code path which didn't use VAO, and had no crash.
>
>
>
> Best Regards
>
> --------------------------------------------------------------------------------------------
>
> Ping Fu
>
> OpenGL-SRDC
>
> AMD SRDC SW Graphics
>
> Desk Phone Ext./DID: 25547
>
> Mobile:86-13671725562
>
> Bldg #47 No.1387 Zhang Dong Road, Zhanghiang Hi-Tech Park, Shanghai PRC
>
> --------------------------------------------------------------------------------------------
>
>
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shader_runner-use-program-before-setting-vao.patch
Type: text/x-patch
Size: 1100 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140403/4b79394e/attachment.bin>