[Piglit] [PATCH] ES spec section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and matrix variable declarations, either the declarat...

[Guo, Johney]

Yes. You are right, either “precision mediump float;"  or “highp” will be OK.
But you can’t leave it as unknown precision qualifer.

From: Petri Latvala [mailto:petri.latvala at intel.com]
Sent: 2014年4月9日 15:49
To: piglit at lists.freedesktop.org
Cc: Ken Phillis Jr; Jin Zhou; Guo, Johney
Subject: Re: [Piglit] [PATCH] ES spec section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and matrix variable declarations, either the declarat...

On 04/09/2014 12:27 AM, Ken Phillis Jr wrote:

The patch looks good, but I would suggest improving commit message... for example...

Title (line 1): GLSL ES fix default precision qualifiers

The OpenGl ES specification for (whatever the version is being checked against)  section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and matrix variable declarations, either the declaration must include a precision qualifier or the default float precision must have been previously declared.


I'm not sure I understand what this patch fixes. I thought the "precision mediump float;" declaration that is present in all those tests is enough.


--
Petri Latvala
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140409/49cb3328/attachment.html>