[Piglit] [PATCH] arb_fcc: Add another test for a gl_FragCoord redeclaration edge case

Chris Forbes chrisf at ijw.co.nz
Tue Apr 15 17:38:29 PDT 2014


OK, let's ignore this patch and get your two landed, then. :)

On Wed, Apr 16, 2014 at 10:44 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> On Sat, Apr 12, 2014 at 10:09 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
>> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
>> ---
>>  .../compiler/redeclaration-around-use.frag         | 31 ++++++++++++++++++++++
>>  1 file changed, 31 insertions(+)
>>  create mode 100644 tests/spec/arb_fragment_coord_conventions/compiler/redeclaration-around-use.frag
>>
>> diff --git a/tests/spec/arb_fragment_coord_conventions/compiler/redeclaration-around-use.frag b/tests/spec/arb_fragment_coord_conventions/compiler/redeclaration-around-use.frag
>> new file mode 100644
>> index 0000000..50dc20f
>> --- /dev/null
>> +++ b/tests/spec/arb_fragment_coord_conventions/compiler/redeclaration-around-use.frag
>> @@ -0,0 +1,31 @@
>> +/* [config]
>> + * expect_result: pass
>> + * glsl_version: 1.10
>> + * require_extensions: GL_ARB_fragment_coord_conventions
>> + * check_link: false
>> + * [end config]
>> + */
>> +
>> +/*
>> + * Section 4.3.x.1 (Input Layout Qualifiers) of the
>> + * ARB_fragment_coord_conventions spec says:
>> + *
>> + *     "Within any shader, the first redeclarations of gl_FragCoord must appear
>> + *     before any use of gl_FragCoord."
>> + */
>> +
>> +#version 110
>> +
>> +#extension GL_ARB_fragment_coord_conventions : require
>> +
>> +in vec4 gl_FragCoord; //first redeclaration: before use.
>> +
>> +vec2 a = gl_FragCoord.xy;
>> +
>> +in vec4 gl_FragCoord; //this redeclaration is ok, because it does not
>> +                      //conflict, and the first redeclaration is before use.
>> +
>> +void main()
>> +{
>> +       gl_FragColor = gl_FragCoord.xyzz;
>> +}
>
> I added this test under spec/glsl-1.50/compiler/fragment_coord_conventions in:
> [PATCH 1/2] glsl-1.50: Add compiler tests to verify gl_FragCoord redeclarations
> Patch is long pending for review. See "use-between-redeclarations-2.frag" test.
>
>> --
>> 1.9.2
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list