[Piglit] More exectest cleanups and refactors v2

Ilia Mirkin imirkin at alum.mit.edu
Wed Apr 16 20:39:04 PDT 2014

Series is

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Not sure what point you were trying to make with self.command not
being None as a result of it being a property -- I don't think that's
the case, if self._command is None, self.command is None will happily
be true. But perhaps it can't be None for other reasons.

$ python
Python 2.7.5 (default, Oct 27 2013, 05:36:27)
[GCC 4.7.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> class x(object):
...   @property
...   def foo(self):
...     return None
>>> t = x()
>>> t.foo is None


On Wed, Apr 16, 2014 at 11:06 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> This is largely the same as the previous version, but with changes
> suggested by Ilia incorperated, and a replacment of v1 patch 9 with v2
> patch 3. This results in a net change of 4 lines from v1 by patch 13,
> with three of those being comments, and the remaining change that an
> assert was moved from Test.run() to Test.command
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

More information about the Piglit mailing list