[Piglit] More exectest cleanups and refactors v2

Dylan Baker baker.dylan.c at gmail.com
Wed Apr 16 23:53:33 PDT 2014


On Wednesday, April 16, 2014 11:39:04 PM Ilia Mirkin wrote:
> Series is
> 
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
> 
> Not sure what point you were trying to make with self.command not
> being None as a result of it being a property -- I don't think that's
> the case, if self._command is None, self.command is None will happily
> be true. But perhaps it can't be None for other reasons.

I though for some reason that the command setter forced the value to be a 
list, but it doesn't. That should probably be fixed too, but I'll do that 
later. I'll fix the commit message before I push.

> 
> $ python
> Python 2.7.5 (default, Oct 27 2013, 05:36:27)
> [GCC 4.7.3] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> 
> >>> class x(object):
> ...   @property
> ...   def foo(self):
> ...     return None
> ...
> 
> >>> t = x()
> >>> t.foo is None
> 
> True
> 
>   -ilia
> 
> On Wed, Apr 16, 2014 at 11:06 PM, Dylan Baker <baker.dylan.c at gmail.com> 
wrote:
> > This is largely the same as the previous version, but with changes
> > suggested by Ilia incorperated, and a replacment of v1 patch 9 with v2
> > patch 3. This results in a net change of 4 lines from v1 by patch 13,
> > with three of those being comments, and the remaining change that an
> > assert was moved from Test.run() to Test.command
> > 
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140416/1e212112/attachment.sig>


More information about the Piglit mailing list