[Piglit] FW: [PATCH] fixed oes compressed etc2 texture miptree failure
Anuj Phogat
anuj.phogat at gmail.com
Fri Apr 25 10:49:46 PDT 2014
On Thu, Apr 24, 2014 at 3:41 AM, Guo, Johney <Weijun.Guo at amd.com> wrote:
> See tests/util/piglit-framework-gl/piglit_glut_framework.c:84:
> default_reshape_func(int w, int h)
> {
> if (piglit_automatic &&
> (w != piglit_width ||
> h != piglit_height)) {
> printf("Got spurious window resize in automatic run "
> "(%d,%d to %d,%d)\n", piglit_width, piglit_height, w, h);
> piglit_report_result(PIGLIT_WARN);
> }
>
> piglit_width = w;
> piglit_height = h;
>
> glViewport(0, 0, w, h);
> }
Yes. It's getting used for Windows.
>
> My OS is win8. If piglit_width < 160, window manager will force it to 160.
> Many piglit tests have set configure width as 150, then they will all report as "warn".
There is a comment about setting the default window width and height in
tests/util/piglit-framework-gl.h:293
/* Default window size. Note: Win7's min window width */ \
/* seems to be 116 pixels. When the window size is */ \
/* unexpectedly resized, tests are marked as "WARN". */ \
/* Let's use a larger default to avoid that. */ \
config.window_width = 150; \
config.window_height = 150; \
As you're describing, it seems like win8 changed the minimum width
requirement. But I don't have windows setup to verify that. It would be
nice if someone verifies it before making all the changes in piglit tests.
> At least the following,
> $ grep -Irne "\<150\>" tests | grep width
> tests/fbo/fbo-blit-d24s8.c:45: config.window_width = 150;
> tests/fbo/fbo-blit.c:43: config.window_width = 150;
> tests/fbo/fbo-copypix.c:40: config.window_width = 150;
> tests/fbo/fbo-readdrawpix.c:40: config.window_width = 150;
> tests/spec/arb_es2_compatibility/arb_es2_compatibility-depthrangef.c:36: config.window_width = 150;
> tests/texturing/incomplete-texture.c:38: config.window_width = 150;
> tests/texturing/shaders/textureSize.c:55: config.window_width = 150;
> tests/texturing/texsubimage.c:42: config.window_width = 150;
> tests/util/piglit-framework-gl.h:272: config.window_width = 150;
>
> What is more, glViewport(0, 0, w, h) will change the viewport to (w,h), so in each glut display() function, glViewPort() should be recalled for validity.
>
>
> -----Original Message-----
> From: Anuj Phogat [mailto:anuj.phogat at gmail.com]
> Sent: 2014年4月24日 7:54
> To: Guo, Johney
> Cc: Ian Romanick; piglit at lists.freedesktop.org
> Subject: Re: [Piglit] FW: [PATCH] fixed oes compressed etc2 texture miptree failure
>
> On Tue, Apr 22, 2014 at 7:41 PM, Guo, Johney <Weijun.Guo at amd.com> wrote:
>> - glut config.window_width should be > 160 so as to avoid warning
>> message.
> What warning are you seeing for width < 160? Add the details to commit message.
>
>> - fopen ktx texture file should be binary mode
>> - viewport need be reset in each display, since it has changed in
>> glut reshape() function
> This test doesn't use glut reshape() function. I think viewport stays unchanged in piglit_display() function.
>
>> Signed-off-by: weijun <weijun.guo at amd.com>
>> ---
>> tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c | 3 ++-
>> tests/util/piglit_ktx.c | 4 ++--
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c
>> b/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c
>> index 59d8748..eeda3cb 100644
>> --- a/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c
>> +++ b/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c
>> @@ -289,6 +289,7 @@ piglit_display(void)
>> bool pass = true;
>>
>> glClear(GL_COLOR_BUFFER_BIT);
>> + glViewport(0, 0, window_width, window_height);
>> for (level = 0; level < num_levels; ++level) {
>> glUniform2f(level_pixel_size_loc,
>> (float) level_width, @@ -339,7 +340,7 @@
>> PIGLIT_GL_TEST_CONFIG_BEGIN
>>
>> config.supports_gl_es_version = 30;
>>
>> - config.window_width = 150;
>> + config.window_width = 160;
>> config.window_height = 150;
>> config.window_visual = PIGLIT_GL_VISUAL_DOUBLE |
>> PIGLIT_GL_VISUAL_RGBA; PIGLIT_GL_TEST_CONFIG_END diff --git
>> a/tests/util/piglit_ktx.c b/tests/util/piglit_ktx.c index
>> b60f737..d844540 100644
>> --- a/tests/util/piglit_ktx.c
>> +++ b/tests/util/piglit_ktx.c
>> @@ -436,7 +436,7 @@ piglit_ktx_read_file(const char *filename)
>> if (self == NULL)
>> goto out_of_memory;
>>
>> - file = fopen(filename, "r");
>> + file = fopen(filename, "rb");
>> if (file == NULL)
>> goto bad_open;
>>
>> @@ -521,7 +521,7 @@ piglit_ktx_write_file(struct piglit_ktx *self, const char *filename)
>> size_t size_written = 0;
>> bool ok = true;
>>
>> - file = fopen(filename, "w");
>> + file = fopen(filename, "wb");
>> if (file == NULL)
>> goto bad_open;
>>
>> --
>> 1.8.4.msysgit.0
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit
More information about the Piglit
mailing list