[Piglit] FW: [PATCH] fixed oes compressed etc2 texture miptree failure

[Ian Romanick]

On 04/24/2014 03:41 AM, Guo, Johney wrote:
> See tests/util/piglit-framework-gl/piglit_glut_framework.c:84:
> default_reshape_func(int w, int h)
> {
> 	if (piglit_automatic &&
> 	    (w != piglit_width ||
> 	     h != piglit_height)) {
> 		printf("Got spurious window resize in automatic run "
> 		       "(%d,%d to %d,%d)\n", piglit_width, piglit_height, w, h);
> 		piglit_report_result(PIGLIT_WARN);
> 	}
> 
> 	piglit_width = w;
> 	piglit_height = h;
> 
> 	glViewport(0, 0, w, h);
> }
> 
> My OS is win8. If piglit_width < 160, window manager will force it to 160.

There was a similar issue a few years ago with Win7.  I believe Brian
Paul fixed this by modifying the framework to enforce a minimum window
size depending on the operating system.  It's better to fix this issue
once for all tests than change each individual test.  This is especially
true since we may add more tests with too-small window sizes (since
we're not on Windows).

Brian, does that sound right?

> Many piglit tests have set configure width as 150,  then they will all report as "warn".
> At least the following,
> $ grep -Irne "\<150\>" tests | grep width
> tests/fbo/fbo-blit-d24s8.c:45:  config.window_width = 150;
> tests/fbo/fbo-blit.c:43:        config.window_width = 150;
> tests/fbo/fbo-copypix.c:40:     config.window_width = 150;
> tests/fbo/fbo-readdrawpix.c:40: config.window_width = 150;
> tests/spec/arb_es2_compatibility/arb_es2_compatibility-depthrangef.c:36:        config.window_width = 150;
> tests/texturing/incomplete-texture.c:38:        config.window_width = 150;
> tests/texturing/shaders/textureSize.c:55:       config.window_width = 150;
> tests/texturing/texsubimage.c:42:       config.window_width = 150;
> tests/util/piglit-framework-gl.h:272:                config.window_width = 150;
> 
> What is more, 	glViewport(0, 0, w, h)  will change the viewport to (w,h),  so in each glut display() function, glViewPort() should be recalled for validity.