[Piglit] [PATCH 1/8] shader_runner: Clamp the SIZE directive to the platform's minimum size.

Ilia Mirkin imirkin at alum.mit.edu
Fri Aug 29 14:48:18 PDT 2014


On Fri, Aug 29, 2014 at 5:41 PM, Eric Anholt <eric at anholt.net> wrote:
> I want to start declaring small sizes in shader_runner tests, but we
> need to avoid angering win8.

Can I put in a good word for POT sizes?

> ---
>  tests/shaders/shader_runner.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index 82b834d..b2bde04 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -1121,9 +1121,17 @@ get_required_config(const char *script_name,
>         parse_required_config(&parse_results, script_name);
>         choose_required_gl_version(&parse_results, &required_gl_version);
>
> +       /* If the shader has a SIZE directive, then make the window
> +        * only that big (but constrained by whatever the platform's
> +        * limits on window size are).
> +        */
>         if (parse_results.found_size) {
>                 config->window_width = parse_results.size[0];
>                 config->window_height = parse_results.size[1];
> +#if defined(_WIN32)
> +                config.window_width = MAX2(config.window_width, 160);

Surely you meant config->window_width/height?

> +                config.window_height = MAX2(config.window_height, 160);
> +#endif
>         }
>
>         if (required_gl_version.es) {
> --
> 2.1.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list