[Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

Emil Velikov emil.l.velikov at gmail.com
Sun Dec 14 07:48:53 PST 2014


On 12/12/14 15:00, Jose Fonseca wrote:
> On 23/11/14 15:09, Emil Velikov wrote:
>> On 23/11/14 09:38, Jose Fonseca wrote:
>>> On 21/11/14 19:52, Emil Velikov wrote:
>> [snip]
>>>> --- /dev/null
>>>> +++ b/tests/util/piglit-framework-gl/piglit_wgl_framework.c
>> [snip]
>>>> +static void
>>>> +enter_event_loop(struct piglit_winsys_framework *winsys_fw)
>>>> +{
>>>> +
>>>> +    /* FINISHME: Write event loop for Windows.
>>>> +     *
>>>> +     * Until we have proper Windows/WGL support, give the user enough
>>>> +     * time to view the window by sleeping.
>>>> +     */
>>>> +    Sleep(8000);
>>>
>>> Instead of Sleep for 8 secs, you could do
>>>
>>>    fprintf(stderr, "Press any key when done.\n");
>>>    getchar().
>>>
>>> It would be more practical, and self-documenting.
>>>
>> Makes sense. Unless there are other comments I'll amend before pushing.
>> The latter of which will happen after waffle 1.5.0 is rolled out.
>>
>> Thanks
>> Emil
>>
> 
> Emil,
> 
> Feel free to push this series.  Or let me know if you rather I do it.
> 
> I actually have a couple of follow-on patches to get this working with
> Mingw better:
> 
>   http://cgit.freedesktop.org/~jrfonseca/piglit/log/?h=wgl-waffle
> 
Will push it out in a second. I wanted to have a few days between the
waffle 1.5.0 release and bumping the minimum requirement in piglit :)

I'm not too trilled with the Mingw fix - things should work like a charm
without it. What are the problems that you're facing without it ?

-Emil


More information about the Piglit mailing list