[Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

[Jose Fonseca]

On 14/12/14 15:48, Emil Velikov wrote:
> On 12/12/14 15:00, Jose Fonseca wrote:
>> On 23/11/14 15:09, Emil Velikov wrote:
>>> On 23/11/14 09:38, Jose Fonseca wrote:
>>>> On 21/11/14 19:52, Emil Velikov wrote:
>>> [snip]
>>>>> --- /dev/null
>>>>> +++ b/tests/util/piglit-framework-gl/piglit_wgl_framework.c
>>> [snip]
>>>>> +static void
>>>>> +enter_event_loop(struct piglit_winsys_framework *winsys_fw)
>>>>> +{
>>>>> +
>>>>> +    /* FINISHME: Write event loop for Windows.
>>>>> +     *
>>>>> +     * Until we have proper Windows/WGL support, give the user enough
>>>>> +     * time to view the window by sleeping.
>>>>> +     */
>>>>> +    Sleep(8000);
>>>>
>>>> Instead of Sleep for 8 secs, you could do
>>>>
>>>>     fprintf(stderr, "Press any key when done.\n");
>>>>     getchar().
>>>>
>>>> It would be more practical, and self-documenting.
>>>>
>>> Makes sense. Unless there are other comments I'll amend before pushing.
>>> The latter of which will happen after waffle 1.5.0 is rolled out.
>>>
>>> Thanks
>>> Emil
>>>
>>
>> Emil,
>>
>> Feel free to push this series.  Or let me know if you rather I do it.
>>
>> I actually have a couple of follow-on patches to get this working with
>> Mingw better:
>>
>>    https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_-7Ejrfonseca_piglit_log_-3Fh-3Dwgl-2Dwaffle&d=AAIDaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=hlGMP0n52wcvFoFYI11nH3-NtL0Uk3qmcS61N4EhoEk&s=9J-DdsZQet3WgtN_0vzQm8mbICcb8wcnZRUSyTflXMU&e=
>>
> Will push it out in a second. I wanted to have a few days between the
> waffle 1.5.0 release and bumping the minimum requirement in piglit :)
>
> I'm not too trilled with the Mingw fix - things should work like a charm
> without it. What are the problems that you're facing without it ?

They are totally broken for me:

- pkg-config doesn't work for cross compiling: it will find the host's 
waffle, instead of the target's waffle (and refuse to build unless the 
host's waffle is not found or has an older version)

- I haven't tried to build with MinGW on Windows natively, but 
pkg-config doesn't exist on Windows AFAIK, so I doubt it works at all there

Besides that the patch also made things easier for those building this 
on Windows.

I splitted that patch into smaller changes, and provided better 
explanations.  I hope it makes more sense now.


Jose