[Piglit] [PATCH] Fix recently introduced GCC warnings in glsl-deriv-varyings

Andres Gomez agomez at igalia.com
Fri Dec 19 17:38:54 PST 2014


On Tue, 2014-12-16 at 20:18 +0100, Andres Gomez wrote:
> Previous patch at:
> http://lists.freedesktop.org/archives/piglit/2014-December/013648.html
> 
> Introduced a couple of GCC warnings in the last 2 newly introduced
> tests.
> 
> After correcting the warnings I'm realizing these tests are exposing
> yet another bug, probably, in glReadPixels.
> 
> This patch removes these 2 tests temporarily while I'm working in this
> new bug. I will re-introduce them once I have a solution for mesa.

Please, ignore this patch. My findings in:
https://bugs.freedesktop.org/show_bug.cgi?id=87407

Are showing a possible bug in the limit values when using dFdx/dFdy in
combination with the abs() modifier.

Ian is recommending in that patch to actually replace this current
piglit test with individual shader_runner tests. I will work in this
direction in the bug above but, in the meanwhile, I'm posting next a
patch for testing the regular values and fix the compilation warnings.

-- 
Br,

Andres



More information about the Piglit mailing list