[Piglit] [PATCH] glsl: Try some chained assignments

Kenneth Graunke kenneth at whitecape.org
Fri Jan 24 13:25:56 PST 2014


On 01/24/2014 11:08 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Mesa currently passes the chained-assignment.vert, but it fails
> chained-assignment-with-array-deref.vert with:
> 
> 0:5(12): error: value of type vec4 cannot be assigned to variable of type float
> 
> It seems the type checker is getting confused by the array
> dereference.
> 
> I have been told that cases similar to
> chained-assignment-with-array-deref pass on all other known desktop
> OpenGL implementations.
> 
> Note: chained-assignment-with-vector-constant-index.vert and
> chained-assignment-with-vector-dynamic-index.vert currently fail on
> Mesa.
> 
> v2: Simplify the constant indexing test slightly (suggested by Ken).
> Add a couple more variations.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>

Looks good.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

These pass with my two Mesa patches which are on the list.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140124/37e6fdc2/attachment.pgp>


More information about the Piglit mailing list