[Piglit] [PATCH 3/4] pbo-readpixels-small: use default window size

Ian Romanick idr at freedesktop.org
Tue Jun 17 15:38:06 PDT 2014


This test is specifically trying to exercise a bug with reading very
small windows.  Changing the window size makes the test useless.  From
the test:

/** @file pbo-readpixels-small.c
 *
 * Tests that reading 2x2 BGRA UNSIGNED_BYTE buffers work correctly.
 *
 * This is the corresponding test to fbo-pbo-readpixels-small test to
 * make sure I didn't break any of the coordinate flipping (sure
 * enough, I did).
 *
 * https://bugs.freedesktop.org/show_bug.cgi?id=25921
 */

I think if the test detects that the window is not 2x2, it should skip
instead.

On 06/08/2014 03:16 PM, Brian Paul wrote:
> ---
>  tests/general/pbo-readpixels-small.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tests/general/pbo-readpixels-small.c b/tests/general/pbo-readpixels-small.c
> index 026531b..900a929 100644
> --- a/tests/general/pbo-readpixels-small.c
> +++ b/tests/general/pbo-readpixels-small.c
> @@ -41,9 +41,6 @@
>  PIGLIT_GL_TEST_CONFIG_BEGIN
>  
>  	config.supports_gl_compat_version = 10;
> -
> -	config.window_width = 2;
> -	config.window_height = 2;
>  	config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>  
>  PIGLIT_GL_TEST_CONFIG_END
> 



More information about the Piglit mailing list