[Piglit] [PATCH 3/4] pbo-readpixels-small: use default window size

[Brian Paul]

On 06/17/2014 04:38 PM, Ian Romanick wrote:
> This test is specifically trying to exercise a bug with reading very
> small windows.  Changing the window size makes the test useless.  From
> the test:
>
> /** @file pbo-readpixels-small.c
>   *
>   * Tests that reading 2x2 BGRA UNSIGNED_BYTE buffers work correctly.
>   *
>   * This is the corresponding test to fbo-pbo-readpixels-small test to
>   * make sure I didn't break any of the coordinate flipping (sure
>   * enough, I did).
>   *
>   * https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D25921&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=U3lly6pC5cZlQF5p0NSkWhYsDZKjaRPJNFk%2FuAp7ttA%3D%0A&s=0074d56be95f7e0b119848efae1c9267aa2927460863109984d6f4d188f73781
>   */
>
> I think if the test detects that the window is not 2x2, it should skip
> instead.

OK, when I (quickly) looked at this I assumed it was the 
glReadPixels(w=2,h=2) that was significant.  I'll post a fix-up patch...

-Brian


>
> On 06/08/2014 03:16 PM, Brian Paul wrote:
>> ---
>>   tests/general/pbo-readpixels-small.c |    3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/tests/general/pbo-readpixels-small.c b/tests/general/pbo-readpixels-small.c
>> index 026531b..900a929 100644
>> --- a/tests/general/pbo-readpixels-small.c
>> +++ b/tests/general/pbo-readpixels-small.c
>> @@ -41,9 +41,6 @@
>>   PIGLIT_GL_TEST_CONFIG_BEGIN
>>
>>   	config.supports_gl_compat_version = 10;
>> -
>> -	config.window_width = 2;
>> -	config.window_height = 2;
>>   	config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>>
>>   PIGLIT_GL_TEST_CONFIG_END
>>