[Piglit] [RESEND][PATCH 1/2] GL 3.2: Use standard internalformat when testing FramebufferTexture

Fabian Bieler fabianbieler at fastmail.fm
Tue Mar 4 13:45:53 PST 2014


On 2014-03-04 22:17, Emil Velikov wrote:
> On 04/03/14 20:42, Anuj Phogat wrote:
>> On Tue, Mar 4, 2014 at 9:18 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> GL_RGB32F is available only when texture_buffer_object_rgb32 is supported.
>>> As the test covers different topic simply replace the format with one
>>> that is supported by both core and compat profile and does not require
>>> any extensions.
>>>
>>> Cc: Jacob Penner <jkpenner91 at gmail.com>
>>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>>> ---
>>>
>>>   .../spec/gl-3.2/layered-rendering/framebuffertexture-buffer-textures.c  | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/spec/gl-3.2/layered-rendering/framebuffertexture-buffer-textures.c b/tests/spec/gl-3.2/layered-rendering/framebuffertexture-buffer-textures.c
>>> index c85e080..331b098 100644
>>> --- a/tests/spec/gl-3.2/layered-rendering/framebuffertexture-buffer-textures.c
>>> +++ b/tests/spec/gl-3.2/layered-rendering/framebuffertexture-buffer-textures.c
>>> @@ -53,7 +53,7 @@ piglit_init(int argc, char **argv)
>>>          glGenTextures(1, &tex);
>>>          glBindTexture(GL_TEXTURE_BUFFER, tex);
>>>
>>> -       glTexBuffer(GL_TEXTURE_BUFFER, GL_RGB32F, buff);
>>> +       glTexBuffer(GL_TEXTURE_BUFFER, GL_RG32F, buff);
>>>
>>>          pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
>>>
>>> --
>>> 1.9.0
>>>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit
>>
>> Both the patches are:
>> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
>>
> Thank you Anuj, would you mind pushing these. I have push access to
> mesa, but piglit is lacking.
>
> -Emil

Pushed.

Fabian


More information about the Piglit mailing list