[Piglit] Update some docstrings v2

Dylan Baker baker.dylan.c at gmail.com
Sat Mar 15 19:39:45 PDT 2014

On Saturday, March 15, 2014 08:41:15 AM Ilia Mirkin wrote:
> On Sat, Mar 15, 2014 at 8:29 AM, Daniel Vetter <daniel at ffwll.ch> 
> > On Fri, Mar 14, 2014 at 07:41:04PM -0700, Dylan Baker wrote:
> >> [snip]
> >> 
> >> > > I'll throw a patch at the end of the series, do you want me to 
> >> 
> >> I'm gonna take it back, sorry. I don't know that dmesg-warn 
should be
> >> worse than warn, (same for fail) since pass -> dmesg-warn, warn 
> >> dmesg-fail, and fail -> dmesg-fail. Personally I was never a fan of
> >> having
> >> special dmesg- statuses, I feel that a fail is a fail and warn is a 
> >> but I'm not sure that change is correct.
> > 
> > The current ordering seems wrong to me, e.g. if you have a failing 
> > and fix up some dmesg noise you now have a regression.
> And if you add dmesg noise, you have a fix :) printk(), here I come!
> On a mildly note, am I the only one who thinks it's weird that
> transitions to/from (skip, notrun) are considered fixes/regressions?
>   -ilia

I agree, that was changed be someone from my original 
implementation, but obviously it was changed so at least one person 
feels the current behavior is correct.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140315/e6b6eaa3/attachment.sig>

More information about the Piglit mailing list