[Piglit] [V2 3/8] ARB_explicit_uniform_location: test too big uniform array size

[Tapani Pälli]

On 03/14/2014 05:10 PM, Ian Romanick wrote:
> On 03/14/2014 04:23 AM, Tapani Pälli wrote:
>> Tests that array fits in to the boundaries of defined by the spec.
>>
>> v2: fix style issues, use asprintf (Anuj)
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>  tests/all.py                                       |  1 +
>>  .../CMakeLists.gl.txt                              |  1 +
>>  .../arb_explicit_uniform_location/array-toobig.c   | 95 ++++++++++++++++++++++
>>  3 files changed, 97 insertions(+)
>>  create mode 100644 tests/spec/arb_explicit_uniform_location/array-toobig.c
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index 03202cd..8f074c7 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -1927,6 +1927,7 @@ import_glsl_parser_tests(arb_explicit_uniform_location,
>>  add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-minmax')
>>  add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-boundaries')
>>  add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-array-elements')
>> +add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-array-toobig')
>>  
>>  arb_texture_buffer_object = Group()
>>  spec['ARB_texture_buffer_object'] = arb_texture_buffer_object
>> diff --git a/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt b/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>> index 945c80d..fc56e04 100644
>> --- a/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>> +++ b/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>> @@ -12,3 +12,4 @@ link_libraries (
>>  piglit_add_executable (arb_explicit_uniform_location-minmax minmax.c)
>>  piglit_add_executable (arb_explicit_uniform_location-boundaries loc-boundaries.c)
>>  piglit_add_executable (arb_explicit_uniform_location-array-elements array-elements.c)
>> +piglit_add_executable (arb_explicit_uniform_location-array-toobig array-toobig.c)
>> diff --git a/tests/spec/arb_explicit_uniform_location/array-toobig.c b/tests/spec/arb_explicit_uniform_location/array-toobig.c
>> new file mode 100644
>> index 0000000..a13ac88
>> --- /dev/null
>> +++ b/tests/spec/arb_explicit_uniform_location/array-toobig.c
>> @@ -0,0 +1,95 @@
>> +/*
>> + * Copyright © 2014 Intel Corporation
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a
>> + * copy of this software and associated documentation files (the "Software"),
>> + * to deal in the Software without restriction, including without limitation
>> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> + * and/or sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice (including the next
>> + * paragraph) shall be included in all copies or substantial portions of the
>> + * Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>> + * IN THE SOFTWARE.
>> + */
>> +
>> +/**
>> + * \file array-toobig.c
>> + *
>> + *  Tests that array size cannot exceed GL_MAX_UNIFORM_LOCATIONS
>> + *
>> + *  https://www.opengl.org/registry/specs/ARB/explicit_uniform_location.txt
>> + *
>> + *  Specification states : "Valid locations for default-block uniform variable
>> + *                          locations are in the range of 0 to the
>> + *                          implementation-defined maximum number of uniform
>> + *                          locations."
> Guess. :)

Yep, I'm actually a bit puzzled if there are any interactions to other
specs which may specify some range or MAX value. This specification says:

"The explicitly defined locations and the generated locations must be in
the range of 0 to MAX_UNIFORM_LOCATIONS minus one."

Which I interpret like MAX_UNIFORM_LOCATIONS-1 should be the "maximum
number of uniform locations available" and all the uniforms must fit in
to that space, explicit locations and the driver assigned ones as well.
Therefore in the worst case uniforms with explicit location can cause
fragmentation so that the 'regular' ones do not have enough space to fit.


>> + */
>> +#include "piglit-util-gl-common.h"
>> +
>> +PIGLIT_GL_TEST_CONFIG_BEGIN
>> +
>> +	config.supports_gl_compat_version = 20;
>> +	config.window_visual = PIGLIT_GL_VISUAL_RGB;
>> +
>> +PIGLIT_GL_TEST_CONFIG_END
>> +
>> +enum piglit_result
>> +piglit_display(void)
>> +{
>> +	return PIGLIT_FAIL;
>> +}
>> +
>> +const char v_sha[] =
>> +	"vec4 vertex;\n"
>> +	"void main() {\n"
>> +		"gl_Position = vertex;\n"
>> +	"}";
>> +
>> +const char fshader_main[] =
>> +	"#extension GL_ARB_explicit_uniform_location: require\n"
>> +	"layout(location = %d) uniform float a[%d];\n"
>                            ^^
> Since this is always zero, just make it zero.
>
>> +	"void main() {\n"
>> +		"gl_FragColor = vec4(a[%d], 1.0, 1.0, 1.0);\n"
>                                      ^^^^^
> This could be a[a.length() - 1].  This means the shader will need
> '#version 120', but everyone supports GLSL 1.20 at this point.  All the
> Mesa drivers do, anyway.
>
> Doing both of those will trim some stuff from the asprintf below.

OK, will change these

>> +	"}";
>> +
>> +void
>> +piglit_init(int argc, char **argv)
>> +{
>> +	GLuint prog;
>> +	GLint link_status;
>> +	int maxloc, array_size;
>> +	char *f_sha;
>> +
>> +	piglit_require_extension("GL_ARB_explicit_uniform_location");
>> +
>> +	glGetIntegerv(GL_MAX_UNIFORM_LOCATIONS, &maxloc);
>> +
>> +	if (!piglit_check_gl_error(GL_NO_ERROR))
>> +		return false;
> I think you mean
>
>     pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
>
> since this function returns void.

Will fix

>> +
>> +	array_size = maxloc + 1;
>> +
>> +	if (asprintf(&f_sha, fshader_main,
>> +		0, array_size, array_size - 1) == -1)
>> +		piglit_report_result(PIGLIT_FAIL);
>> +
>> +	prog = piglit_build_simple_program_unlinked(v_sha, f_sha);
>> +
>> +	free(f_sha);
>> +
>> +	glLinkProgram(prog);
>> +	glGetProgramiv(prog, GL_LINK_STATUS, &link_status);
>> +	glDeleteProgram(prog);
>> +
>> +	/* link_status is expected to be GL_FALSE */
>> +	piglit_report_result(link_status ? PIGLIT_FAIL : PIGLIT_PASS);
>> +}